-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update for 1.6 issue #23956 #24909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: version-1-6
Are you sure you want to change the base?
Update for 1.6 issue #23956 #24909
Conversation
Ping @narimiran |
|
I'm not sure about dead quite yet. OpenBSD 7.7 was just released yesterday and the only Nim package provided is 1.6.18. I tried compiling Nim 2.2.4 from source on amd64 OpenBSD 7.7 and I ran into minor compilation issues where openbsd wasn't mentioned in a when-case and koch tools failed when compiling nimble because it used posix_fallocate but I was successful after making some minor patches so this made me hopeful to see 2.2 available for a package in the next 7.8 release. I ran testament all and got, what I think is, a decent score: FAILURE! total: 517 passed: 501 skipped: 12 failed: 4 |
This means they not using even the latest released 1.6 version — 1.6.20. If we merge this (and before that, we need to update our CIs in the
|
Right, I'll request for that to be updated. It was 1.6.18 for the last OpenBSD release too.
Understood. Not a problem to skip this merge. I can submit a patch to the OpenBSD package that can add it to 1.6.20. There are already four patches as it is:
Nim 2.0.16 took the exact same patches to allow compiling of tools and got
Yes. issue #24922 and pull #24923 |
try later, if needed, if you get 500 error from the cvsweb openbsd server. they must be getting slammed from the new release |
If we can fix stuff in |
OpenBSD is still on Nim 1.x so the fix for #23956 should be in there too